-
Notifications
You must be signed in to change notification settings - Fork 27
Upgrade dependencies for code-assist MCP server #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
google-labs-jules
wants to merge
8
commits into
main
Choose a base branch
from
upgrade-deps-16750073306688255688
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2f05465
chore: upgrade dependencies
google-labs-jules[bot] 718480f
feat: add MCP prompts and completion support
google-labs-jules[bot] a563c28
feat: add MCP prompts, completions, and fix dependencies
google-labs-jules[bot] 238283e
feat: add MCP prompts, completions, and fix dependencies
google-labs-jules[bot] 4e22fae
feat: add MCP prompts, completions, and fix dependencies
google-labs-jules[bot] 35c30d0
feat: add MCP prompts, completions, and fix dependencies
google-labs-jules[bot] 50ef9a4
feat: add MCP prompts, completions, and fix dependencies
google-labs-jules[bot] 5a73c06
chore: upgrade dependencies (Part 1 of 3)
google-labs-jules[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit brittle since it depends on the semi-unstructured XML response from the /instructions api endpoint for Code Assist middleware. What's a more robust design or any requirements for the upstream API structure or content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, parsing the XML/Markdown structure is brittle. To mitigate this, I've implemented a fail-safe design:
DEFAULT_CONTEXTSlist (inconfig.ts).Ideal Upstream Change: A more robust design would be for the RAG service to return a structured JSON array (e.g.,
api_products) alongside the system instructions, which would eliminate the need for scraping the text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can extend our /instructions endpoint to return a list of api_products but currently we're using XML as the format, we could have a ```json block inside of it with the list of products. If that helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a bad suggestion ☝️ @caio1985 @mmisim to consider how we always provide a consistent list of the available products via Code Assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledged. The current implementation ensures consistency via the hardcoded fallback in
config.ts, while the dynamic fetch offers best-effort freshness.