feature/Nullish coalescing operator and assignment #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saelo
reviewed
Nov 14, 2024
| return self.rawValue | ||
| } | ||
|
|
||
| static public func allCaseWithoutNCO() -> Array<BinaryOperator> { |
Collaborator
There was a problem hiding this comment.
What's the idea behind this? Why is the new operator special?
| case .BitwiseXor: | ||
| try translateBinaryOperation(.Xor) | ||
| case .NCO: | ||
| try translateBinaryOperation(.NCO) |
Collaborator
There was a problem hiding this comment.
You will also need to update the corresponding JavaScript code, see here:
Contributor
Author
There was a problem hiding this comment.
Thanks very much. I missed something here.
| case Exp = "**" | ||
| case UnRShift = ">>>" | ||
| // Nullish coalescing operator (??) | ||
| case NCO = "??" |
Collaborator
There was a problem hiding this comment.
'NCO' is maybe a little weird because none of the other operators have "operator" in their name. 'NC' is maybe a bit short/unintuitive though, so how about just calling it NullCoalesce?
Collaborator
|
I guess this can be closed now after #471? If not, please reopen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some feature about nullish coalescing operator and assignment