refactor: move common parts from (V8Profile|V8HoleFuzzingProfile|V8SandboxProfile).swift to V8CommonProfile.swift #519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndboxProfile).swift to V8CommonProfile.swift
simbahax
force-pushed
the
feature/v8commonprofile
branch
from
c01adae to
b1da06f
Compare
|
(rebased to current main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple profiles for V8 fuzzing exist.
Currently, common functionality is re-implemented in every profile, therefore there is an open todo in some of the profiles.
This PR implements this to ease the implementation of new profiles :)
Point for discussion: The namespace is somewhat polluted here, e.g., other profiles also implement a
GcGenerator.I prefixed these where required, there might be better ways around that.