Skip to content

Pass environment variables to the engine in startup tests #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Liedtke merged 2 commits into from
Oct 20, 2025
Merged

Pass environment variables to the engine in startup tests #535

Liedtke merged 2 commits into from
Oct 20, 2025

Conversation

@CSharperMantle
Copy link
Contributor

@CSharperMantle CSharperMantle commented Oct 17, 2025 •
edited
Loading

This PR helps avoid potential mismatches in behavior between a startup test and subsequent fuzzing based on REPRL sessions.

After this patch, the startup tests on SpiderMonkey produce the following output:

[Fuzzer] Initialized
[Fuzzer] Recommended timeout: at least 1000ms. Current timeout: 10000ms
[Fuzzer] Runner has non-empty output for empty program! This might indicate that some flags are wrong.
[Fuzzer] Output:
[COV] edge counters initialized. Shared memory: shm_id_230610_0 with 398403 edges

Resolves #534.

Liedtke
Liedtke reviewed Oct 20, 2025
View reviewed changes
Sources/Fuzzilli/Util/JavaScriptExecutor.swift Outdated
try inputPipe.fileHandleForWriting.close()

let environment = ProcessInfo.processInfo.environment.merging(
Dictionary(env, uniquingKeysWith: { _, new in new }),
Copy link
Collaborator

@Liedtke Liedtke Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't have to be a Dictionary?

Suggested change
Dictionary(env, uniquingKeysWith: { _, new in new }),
env,

Copy link
Contributor Author

@CSharperMantle CSharperMantle Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I overlooked https://developer.apple.com/documentation/swift/dictionary/merging(_:uniquingkeyswith:)-9bik6 and thought I had to construct a Dictionary explicitly.

@CSharperMantle CSharperMantle force-pushed the feat-nullarg-validator-env branch from 639922f to d2bf8bf Compare October 20, 2025 10:42
Liedtke
Liedtke approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@Liedtke Liedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Liedtke Liedtke merged commit 89168bd into googleprojectzero:main Oct 20, 2025
3 of 4 checks passed
Liedtke pushed a commit that referenced this pull request Oct 20, 2025
@CSharperMantle @Liedtke
Pass environment variables to the engine in startup tests (#535)
91fb4ab 
* Make REPRL env property a list of tuples of (key, value)
* Pass env vars when running startup tests
chase1k pushed a commit to VRIG-RITSEC/fuzzillai that referenced this pull request Nov 13, 2025
@CSharperMantle @chase1k
Pass environment variables to the engine in startup tests (googleproj…
8570494 
…ectzero#535)

* Make REPRL env property a list of tuples of (key, value)
* Pass env vars when running startup tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liedtke Liedtke Liedtke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Environment variable SHM_ID is not passed to the engine in startup tests

2 participants

@CSharperMantle @Liedtke