Skip to content

Reverse conditional checker #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Reverse conditional checker #729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Upcoming
* Android Resolver - Reverse conditional checker for `packaging` keyword in maintemplate based on android gradle plugin version. Fixes #715

# Version 1.2.184 - Jan 28, 2025
* Android Resolver - Update and resolve `packaging` keyword in maintemplate
based on android gradle plugin version.
Expand Down
2 changes: 1 addition & 1 deletion source/AndroidResolver/src/PlayServicesResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2354,7 +2354,7 @@ internal static IList<string> PackagingOptionsLines(ICollection<Dependency> depe
lines.Add("android {");

// `packagingOptions` is replaced by `packaging` keyword in Android Gradle plugin 8.0+
if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) <= 0) {
if ((new Dependency.VersionComparer()).Compare("8.0", AndroidGradlePluginVersion) >= 0) {
lines.Add(" packaging {");
} else {
lines.Add(" packagingOptions {");
Expand Down
Loading