-
Notifications
You must be signed in to change notification settings - Fork 6
fix: Add SSR support by enforcing client-side rendering and using dynamic imports #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 535e7e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello @jpoehnelt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully introduces Server-Side Rendering (SSR) compatibility for the React Drive Picker components. This is achieved by correctly applying the "use client" directive and dynamically importing the underlying web component within a useEffect hook, ensuring browser-specific API usage is deferred to the client-side. The accompanying documentation updates in the README files clearly explain the SSR considerations and remove the outdated Svelte demo. Overall, the changes align with the stated objective.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds Server-Side Rendering (SSR) support for the @googleworkspace/drive-picker-react component by using dynamic imports to ensure the underlying web component is only loaded on the client. It also introduces error handling for when the web component fails to load. The changes are logical and well-tested.
My main feedback is a critical fix for the new loader.ts file to prevent a potential infinite render loop in the DrivePicker component. While a general rule suggests avoiding promise-caching for idempotent script injection, it is necessary here to prevent a critical bug.
|
Decided to ignore error handling until further feedback is received. |
related vercel/next.js#77475 (comment)