fix: export prop types from manifest/jsdoc#52
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the export of prop types by removing the legacy types file and introducing a new props file generated from the custom elements manifest. Key changes include:
- Updating src/index.ts and src/drive-picker/index.ts to export new prop type definitions.
- Removing src/drive-picker/types.ts and generating prop types in src/drive-picker/props.ts via a new build:props script.
- Adjusting custom-elements.json and README.md to reflect the new prop types and provide updated React/JSX usage instructions.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.ts | Updated export statements to include new prop interface types from "./drive-picker". |
| src/drive-picker/types.ts | Removed as prop types have been moved to the new props.ts file. |
| src/drive-picker/props.ts | New file that defines prop interfaces for DrivePicker components. |
| src/drive-picker/index.ts | Re-exports new prop types from props.ts. |
| scripts/props.ts | Added script to auto-generate the prop types from the custom elements manifest. |
| package.json | Added the build:props command and its configuration. |
| custom-elements.json | Updated to map prop type declarations to the new props file. |
| README.md | Added documentation for React/JSX usage with updated prop types. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export props and update README for instructions on JSX.
closes #51