fix: [Python] Auth App #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+102
to
+104
| { | ||
| "text": "Failed to log out user %s: ```%s```" % (user_name, e), | ||
| } |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
PierrickVoulet
approved these changes
Nov 14, 2024
python/auth-app/README.md
Outdated
| ``` | ||
| gcloud app deploy | ||
| ``` | ||
| 1. Fetch the URL: |
Contributor
There was a problem hiding this comment.
nit: describe the expected result
Contributor
Author
There was a problem hiding this comment.
Updated the instructions
python/auth-app/README.md
Outdated
| gcloud app browse | ||
| ``` | ||
| 1. Replace the `redirect_uris` in your `client_secrets.json` with `<URL from the previous step>/auth/callback`. | ||
| 1. Create a [service account](https://support.google.com/a/answer/7378726?hl=en#) |
Contributor
There was a problem hiding this comment.
Remove hl=en from the URL parameters
Contributor
Author
There was a problem hiding this comment.
Updated the instructions
| CLIENT_SECRET_PATH: "client_secret.json" | ||
| SESSION_SECRET: "notasecret" | ||
|
|
||
| service_account: <SERVICE_ACCOUNT> |
Contributor
There was a problem hiding this comment.
I'm assuming that this value needs to be set before deploying, should we add an additional step in the README instructions?
Alternatively, you could add a quick comment that define what it is.
Contributor
Author
There was a problem hiding this comment.
Updated the instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.