merge channels, use <audio> tag and support live streams #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for bringing this legendary audio visualizer to the web!
I really wanted to be able to use it for live radio streams (icecast / shoutcast), so I made some adjustments here:
[If I misinterpreted the situation / made the wrong assumption about stereo not being relevant for visualization, please do let me know. Would be great if you could show me an example of a song where the difference is noticeable! ]
Because we now no longer have to detect the amount of channels of the source, we don't need custom decode audio logic anymore, and we can just rely on the functionality of an
<audio>element instead.<audio>elements are perfectly able to play live streams from icecast/shoutcast sources! 🎉 - so let's add a field to input a stream URL on the demo index page.Please let me know what you think - I'm happy to modify / further improve if necessary.
Live demo: https://oele.net/goom-online/