Skip to content

feat: warn when system keyring is unavailable#3357

Open
acaloiaro wants to merge 1 commit intogopasspw:masterfrom
acaloiaro:acaloiaro/age/warn-when-keyring-unavailable
Open

feat: warn when system keyring is unavailable#3357
acaloiaro wants to merge 1 commit intogopasspw:masterfrom
acaloiaro:acaloiaro/age/warn-when-keyring-unavailable

Conversation

@acaloiaro
Copy link
Copy Markdown

@acaloiaro acaloiaro commented Mar 14, 2026

Summary

  • Emit a one-time warning when age.usekeychain is enabled but no OS keyring provider is available, so users understand why passphrase caching won't persist across sessions
  • Warn when writing a passphrase to the OS keyring fails at runtime
  • The cacher.Set and askPass.Passphrase signatures now accept a context.Context to support the warning output
  • Add tests for askPass initialization, osKeyring get/set paths, and the user-facing warning

@acaloiaro acaloiaro force-pushed the acaloiaro/age/warn-when-keyring-unavailable branch 7 times, most recently from 11a28f0 to 380d679 Compare March 14, 2026 18:13
Signed-off-by: Adriano Caloiaro <code@adriano.fyi>
@acaloiaro acaloiaro marked this pull request as ready for review March 14, 2026 18:14
Copy link
Copy Markdown
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the lint issue and then we're good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants