feat: warn when system keyring is unavailable#3357
Open
acaloiaro wants to merge 1 commit intogopasspw:masterfrom
Open
feat: warn when system keyring is unavailable#3357acaloiaro wants to merge 1 commit intogopasspw:masterfrom
acaloiaro wants to merge 1 commit intogopasspw:masterfrom
Conversation
11a28f0 to
380d679
Compare
Signed-off-by: Adriano Caloiaro <code@adriano.fyi>
dominikschulz
requested changes
Apr 3, 2026
Member
dominikschulz
left a comment
There was a problem hiding this comment.
LGTM. Please fix the lint issue and then we're good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
age.usekeychainis enabled but no OS keyring provider is available, so users understand why passphrase caching won't persist across sessionscacher.SetandaskPass.Passphrasesignatures now accept acontext.Contextto support the warning outputaskPassinitialization,osKeyringget/set paths, and the user-facing warning