Skip to content

Align builder with spx v2.0.0-pre.48 and keep the existing release precheck flow#2992

Merged
aofei merged 6 commits intodevfrom
copilot/upgrade-spx-to-v2-0-0-pre-48-again
Mar 30, 2026
Merged

Align builder with spx v2.0.0-pre.48 and keep the existing release precheck flow#2992
aofei merged 6 commits intodevfrom
copilot/upgrade-spx-to-v2-0-0-pre-48-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 27, 2026

Updates the repository’s SPX dependency and runtime references to v2.0.0-pre.48 while preserving the existing spx-gui installer behavior.

Changes Made

  • Bump github.com/goplus/spx/v2 to v2.0.0-pre.48 across the Go tool modules.
  • Update spx-gui’s configured SPX version to 2.0.0-pre.48.
  • Keep spx-gui/install-spx.sh on the previous wget --spider precheck flow before downloading the GitHub release asset.
  • Preserve the existing GHCR fallback path when the release asset is not available.

Validation

  • Checked recent GitHub Actions workflow runs for this branch.
  • Verified the installer script syntax with bash -n spx-gui/install-spx.sh.

The changes remain focused on aligning Builder with spx v2.0.0-pre.48 without changing the established installer flow.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits March 27, 2026 06:19
Copilot AI requested a review from nighca March 27, 2026 06:30
@nighca nighca marked this pull request as ready for review March 27, 2026 06:46
Copilot AI review requested due to automatic review settings March 27, 2026 06:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s SPX dependency/runtime references to v2.0.0-pre.48 and simplifies spx-gui runtime installation by removing the separate GitHub release “precheck” request in favor of a single download attempt with fallback to GHCR.

Changes:

  • Bump github.com/goplus/spx/v2 to v2.0.0-pre.48 across Go tool modules (tools/ai, tools/ispx, tools/spxls).
  • Update spx-gui’s configured SPX version (.env) and installer script to 2.0.0-pre.48.
  • Modify install-spx.sh to skip wget --spider and instead attempt the release download directly, falling back to GHCR if it fails.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/spxls/go.sum Updates summed module version for spx/v2 to v2.0.0-pre.48.
tools/spxls/go.mod Bumps spx/v2 indirect dependency to v2.0.0-pre.48.
tools/ispx/go.sum Updates summed module version for spx/v2 to v2.0.0-pre.48.
tools/ispx/go.mod Bumps spx/v2 requirement to v2.0.0-pre.48.
tools/ai/go.sum Updates summed module version for spx/v2 to v2.0.0-pre.48.
tools/ai/go.mod Bumps spx/v2 requirement to v2.0.0-pre.48.
spx-gui/install-spx.sh Updates SPX runtime version and removes the release existence precheck step.
spx-gui/.env Keeps VITE_SPX_VERSION aligned with installer script at 2.0.0-pre.48.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xgopilot
Copy link
Copy Markdown
Contributor

xgopilot bot commented Mar 27, 2026

Clean and correct change. Collapsing the --spider preflight + download into a single wget attempt eliminates a redundant network round-trip on every successful build — a nice improvement. Version is consistently updated across all Go modules and the env file. Only minor suggestion left inline.

Copilot AI changed the title Skip spx release precheck and align builder with spx v2.0.0-pre.48 Align builder with spx v2.0.0-pre.48 and keep the existing release precheck flow Mar 30, 2026
Copilot AI requested a review from aofei March 30, 2026 02:21
…ld scripts

Remove instructions to execute install-spx.sh and build-wasm.sh, and add
an explicit prohibition against modifying or executing any shell scripts.
The agent should only update version references in .env files and Go modules.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>
…d scripts

Refine the spx-upgrader instructions: the agent may update version references
in installation and build scripts, but must not make any other changes to those
files, and must not execute them.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>
Add back the two required execution steps in spx-upgrader agent instructions:
execute install-spx.sh to download runtime assets and build-wasm.sh to build
Wasm components. These steps are required as part of the upgrade workflow.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>
@aofei aofei enabled auto-merge (squash) March 30, 2026 03:03
@aofei aofei merged commit a233d8a into dev Mar 30, 2026
7 checks passed
nighca added a commit to nighca/goplus-builder that referenced this pull request Mar 30, 2026
…echeck flow (goplus#2992)

* chore: skip spx release precheck and upgrade to pre.48

Agent-Logs-Url: https://github.com/goplus/builder/sessions/9bff7c43-def4-467f-a4ff-6500f5bd83c4

Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

* refactor: simplify spx install fallback flow

Agent-Logs-Url: https://github.com/goplus/builder/sessions/9bff7c43-def4-467f-a4ff-6500f5bd83c4

Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>

* fix: restore spx installer precheck flow

Agent-Logs-Url: https://github.com/goplus/builder/sessions/a014d310-3c52-46e6-b0c1-ba50b4dcc6a1

Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>

* docs(agents): prohibit spx-upgrader from touching installation or build scripts

Remove instructions to execute install-spx.sh and build-wasm.sh, and add
an explicit prohibition against modifying or executing any shell scripts.
The agent should only update version references in .env files and Go modules.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>

* docs(agents): allow version reference updates in installation or build scripts

Refine the spx-upgrader instructions: the agent may update version references
in installation and build scripts, but must not make any other changes to those
files, and must not execute them.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>

* fix: restore spx installer precheck flow

Add back the two required execution steps in spx-upgrader agent instructions:
execute install-spx.sh to download runtime assets and build-wasm.sh to build
Wasm components. These steps are required as part of the upgrade workflow.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: nighca <1492263+nighca@users.noreply.github.com>
Co-authored-by: aofei <5037285+aofei@users.noreply.github.com>
Co-authored-by: xgopilot <noreply@goplus.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants