Skip to content

Revert "feat(modfile): add run directive support for custom project runners"#131

Merged
xushiwei merged 1 commit intomainfrom
revert-126-runner
Jan 17, 2026
Merged

Revert "feat(modfile): add run directive support for custom project runners"#131
xushiwei merged 1 commit intomainfrom
revert-126-runner

Conversation

@xushiwei
Copy link
Member

Reverts #126

@gemini-code-assist
Copy link

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a full reversion of a previous feature that enabled the specification of custom project runners via a runner directive in gop.mod files. The change systematically removes all associated parsing logic, data structures, and test cases, effectively eliminating support for this directive from the modfile package. This ensures that the modfile package no longer recognizes or processes the runner directive.

Highlights

  • Reversion of runner directive support: This pull request completely reverts the functionality that introduced the runner directive for custom project runners in gop.mod files.
  • Code Removal: The Runner struct and its corresponding field within the Project struct have been removed. Additionally, the parsing logic for the runner directive within the modfile package has been deleted.
  • Test Case Updates: Existing test cases in modfile/gop_test.go have been updated to reflect the absence of the runner directive, including adjustments to expected statement counts and the removal of runner-specific error tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xushiwei xushiwei merged commit 8227ac4 into main Jan 17, 2026
9 checks passed
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.22%. Comparing base (25c02e4) to head (493aeb4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   93.43%   93.22%   -0.22%     
==========================================
  Files           6        6              
  Lines         701      679      -22     
==========================================
- Hits          655      633      -22     
  Misses         28       28              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the feature that added support for a run directive for custom project runners. The changes correctly remove the Runner struct, the parsing logic for the runner directive, and associated tests. The adjustments in test files, such as updating statement counts and indices, are consistent with the removal. The revert appears to be clean and complete, and I found no issues with the changes.

@xgopilot
Copy link

xgopilot bot commented Jan 17, 2026

Code Review Summary

Comprehensive review completed across code quality, performance, documentation, security, and simplification.

Result: No noteworthy issues found.

This is a clean revert that properly removes the runner directive feature. All tests pass, documentation is consistent, and there are no security concerns. The changes are minimal and correctly undo PR #126.

✅ Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant