Skip to content

Comments

Better solution to support FreeBSD in the future#1148

Merged
BoboTiG merged 7 commits intogorakhargosh:masterfrom
blitztide:master
Dec 22, 2025
Merged

Better solution to support FreeBSD in the future#1148
BoboTiG merged 7 commits intogorakhargosh:masterfrom
blitztide:master

Conversation

@blitztide
Copy link
Contributor

No description provided.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 22, 2025

Let me know if my changes are OK for you.

@blitztide
Copy link
Contributor Author

Don't comment remove FreeBSD from returning platform_BSD as that will break FreeBSD before version 15

@blitztide
Copy link
Contributor Author

I've not checked all previously supported versions to see if the same uname approach will work on older versions. But we know that the current one appears to work.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Dec 22, 2025

The behavior won't change. I rewoked a bit the logic to not test twice for "freebsd".

Copy link
Contributor Author

@blitztide blitztide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes :)

@BoboTiG BoboTiG merged commit 2ecaf04 into gorakhargosh:master Dec 22, 2025
21 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants