-
Notifications
You must be signed in to change notification settings - Fork 109
fix: add test dbs back #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add test dbs back #1346
Conversation
Summary of ChangesHello @hwbrzzl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the testing infrastructure by reintroducing support for MySQL, SQL Server, and SQLite database queries within the test suite. The change ensures that the application's interactions with these database systems are properly validated, aligning with a broader initiative to follow 'Gemini' standards and directly resolving a previously identified issue. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request re-enables tests for MySQL, SQL Server, and SQLite databases by uncommenting the relevant code in the All method. The change is correct and achieves its goal. I've added a suggestion to refactor the All method for better readability and consistency with other parts of the code.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.16.x #1346 +/- ##
==========================================
Coverage ? 68.04%
==========================================
Files ? 215
Lines ? 11601
Branches ? 0
==========================================
Hits ? 7894
Misses ? 3327
Partials ? 380 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
π Description
Closes goravel/goravel#856
Follow Gemini
β Checks