fix: check md5 without == at the end (#2)#5
Open
emoriarty wants to merge 1 commit intogordienko:masterfrom
Open
fix: check md5 without == at the end (#2)#5emoriarty wants to merge 1 commit intogordienko:masterfrom
emoriarty wants to merge 1 commit intogordienko:masterfrom
Conversation
* fix: check md5 without == at the end * reponse > response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MD5 (or whatever algorithm) is supposed to always generate the same output.
I do not understand what use case requires appending the double equal (==) at the end of the Content-MD5 header.
Anyway, I think this fix helps to support both cases in which double equal is present or not at the end of the header.