Skip to content

draft: user-profile-setting-page#1545

Draft
Kevin-Chu58 wants to merge 2 commits intodevelopfrom
user-profile-setting-page
Draft

draft: user-profile-setting-page#1545
Kevin-Chu58 wants to merge 2 commits intodevelopfrom
user-profile-setting-page

Conversation

@Kevin-Chu58
Copy link
Contributor

@Kevin-Chu58 Kevin-Chu58 commented Oct 17, 2022

Links #1415.

@Kevin-Chu58 Kevin-Chu58 marked this pull request as draft October 17, 2022 18:11
@bennettforkner
Copy link
Contributor

Loving this progress so far -- are you hoping to put more work in before the end of the semester?

@Kevin-Chu58
Copy link
Contributor Author

Kevin-Chu58 commented Nov 29, 2022

Loving this progress so far -- are you hoping to put more work in before the end of the semester?

For now, I am not prioritizing the setting page over the student news bugs. For it requires more discussion on how to classify different setting groups, like the settings users take full control (privacy settings, upload profile images), and the settings that requires the involvement of certain departments (updating personal information). The latter one definitely needs inspiration to handle how to show the changes are in progress or have been completed.

Currently, this pr is simply a draft for the future development on setting page. It only has one privacy toggle (clifton strength) to show it's working properly. I will try to add more settings for the ones users possess full control. Though I haven't figure out how to implement the latter case (possibly sending an email, or use notification in the future once change is completed if RecIM notification works properly and it may get integrated to the whole 360 site?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants