Open
Conversation
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Author
|
not stale... |
Owner
|
i will look into it tomorrow, thanks for submitting this PR |
|
Thanks Mo and Linus! Appreciate it. I was about to open a pull request for this. |
|
Is it possible for you to merge this as well @gorhom ? I see that you released another version but without these changes. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not stale. |
|
Can this be merged? |
|
Also would be interested in this being merged |
|
Merge please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The deprecated
AnimatePropstype was removed in reanimated version 4.1.0 (in a minor version 😅) which made this stop working...The replacement
AnimatedPropsis available in version 3 as well, so this should work on both versions of reanimated 🎉