[cors]: allow users to disable preflight caching

[jub0bs]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

Related Tickets & Documents

• Related Issue [FEATURE] Allow users to disable caching of preflight responses #246
• Closes [FEATURE] Allow users to disable caching of preflight responses #246

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

[jub0bs]

No feedback from maintainers in more than three months... Is this project still maintained?

[AlexVulaj]

@jub0bs Hey there - we're a small team coming out of a large transitional process and doing our best to keep on top of things, mainly prioritizing bugs and other issues over new features still. We appreciate your patience as we work through our large backlog, and thanks for contributing!

[jub0bs]

No reactivity from maintainers. Closing this PR.

[jaitaiwan]

I took a brief look, I think the bool is unnecessary. I need to look at if the maxAge has a default value when unset but it appears to me we’d just change the condition to > -1.

[jub0bs]

@jaitaiwan See #250, which also aims to fix #246 but in a slightly different way.

Additional resources on the topic:

• https://jub0bs.com/posts/2023-02-08-fearless-cors/#impossibility-to-turn-preflight-caching-off
• https://pkg.go.dev/github.com/jub0bs/cors#hdr-MaxAgeInSeconds