Rescue gracefully not found error for detailed responses#98
Rescue gracefully not found error for detailed responses#98DanielYouCan wants to merge 1 commit intogoshippo:masterfrom
Conversation
When creating a manifest with invalid data and bad request error should be returned, GoShippo API instead returns 404 Not found error. Gem should be able to rescue such errors until proper error will be returned on server side.
|
Thanks for making a pull request! We are still attempting to figure out how to handle SDK support (especially for this gem). There are a number of things that haven't been included in this API wrapper (like our orders endpoint-> https://goshippo.com/docs/reference#orders). I've been working with manifests quite a bit recently with customers and think a more specific error response code would be helpful! What sort of error response message were you expecting? Was there something wrong with the manifest request that we should have surfaced for you? For example you can only setup a manifest (aka scanform) with USPS for domestic mail (not PR or MIL addresses) but currently we don't out out the difference between those and say a tracking number that has already been included in another manifest. |
|
@jfriedr GoShippo API returns such error and 404 not found.
But the gem doesn't handle this properly and loses such errors. As you can see such errors can happen if a shipment has different pickup date, address zip code or carrier than manifest |
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
When creating a manifest with invalid data and bad request error should be returned,
GoShippo API instead returns 404 Not found error.
Gem should be able to rescue such errors until proper error will be
returned on server side.