feat: Add support for specifying URL Query params in HTTP resource#1013
Open
riton wants to merge 2 commits intogoss-org:masterfrom
Open
feat: Add support for specifying URL Query params in HTTP resource#1013riton wants to merge 2 commits intogoss-org:masterfrom
riton wants to merge 2 commits intogoss-org:masterfrom
Conversation
3 tasks
2 tasks
aelsabbahy
reviewed
May 1, 2025
Member
aelsabbahy
left a comment
aelsabbahy
left a comment
There was a problem hiding this comment.
This is a nice addition, I added one small comment regarding support for duplicate keys.
riton
force-pushed
the
feature/http_query_params
branch
from
f14a2d1 to
6d1142d
Compare
riton
force-pushed
the
feature/http_query_params
branch
from
6d1142d to
3669540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This P.R adds support for specifying URL query params in the
httpresource.This will properly handle URL encoding as opposed to specifying raw query params directly in the
url.📚 Documentation preview 📚: https://goss--1013.org.readthedocs.build/en/1013/