Skip to content

Update golang-lint CI to final v1 release: v1.64.8#1038

Open
kgaughan wants to merge 1 commit intogoss-org:masterfrom
kgaughan:golangci-lint-upgrade
Open

Update golang-lint CI to final v1 release: v1.64.8#1038
kgaughan wants to merge 1 commit intogoss-org:masterfrom
kgaughan:golangci-lint-upgrade

Conversation

@kgaughan
Copy link

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

This update is needed to cover some spurious failing typecheck golangci-lint tests that start being flagged if the dependencies are upgraded.

Additionally, fix up a few minor issues caught by it.

Just to note, but when I ran make test-linux-all on the master branch, the integration tests aren't working as expected because there have been some changes in the packages in RockyLinux, issues with DNS records exposed by dnstest.io, and a few other such issues. I get the same set of issues running on either the master branch or on the PR. It looks like some work is needed to fix the integration tests separately from all this.

Additionally, fix up a few minor issues caught by it.
@petemounce
Copy link
Collaborator

lgtm. I don't know (yet), however, how come Travis or the github workflows have not run.

@kgaughan
Copy link
Author

@petemounce, @aelsabbahy or another maintainer needs to allow them to be triggered. It's a guard GH puts in place to prevent the service to be DOS'd by malicious pull requests.

@petemounce
Copy link
Collaborator

@petemounce, @aelsabbahy or another maintainer needs to allow them to be triggered. It's a guard GH puts in place to prevent the service to be DOS'd by malicious pull requests.

That's what I figure too. However, I do not see in the UI any workflows awaiting approval as the docs suggest I should.

@ripienaar
Copy link
Collaborator

It's possible travis needs to be re-authenticated

@kgaughan
Copy link
Author

@ripienaar How would we go about getting that fixed up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants