Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This PR updates
docs/schema.yamlso that thefileTest.filetypeenum fully reflects all file types that the runtime (system/file.go) can return. Previously, the schema only listedfile,symlink, anddirectory. It now includes:filesymlinkdirectorysocketcharacter-deviceblock-devicepipeAdditionally, the description of the
fileresource was expanded to enumerate these types.Motivation:
Tools (IDEs, schema validators, autocomplete) relying on
docs/schema.yamlwere unaware of valid values likesocket, causing false validation errors and poorer authoring experience. Aligning the schema with the runtime improves correctness and usability.Evidence:
Supported types are returned by
DefFile.Filetype()insystem/file.go:📚 Documentation preview 📚: https://goss--1041.org.readthedocs.build/en/1041/