Skip to content

Avoid unaligned data access for grasshopper cipher. #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shanechko wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Avoid unaligned data access for grasshopper cipher. #376

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cf43b72
Avoid unaligned data access for grasshopper ctracpkm.
shanechko Dec 5, 2021
8c5ee08
Fix align-cast for gost_grasshopper_cipher_key.
shanechko Dec 12, 2021
55bae42
Fix align-cast for gost_grasshopper_master_key.
shanechko Dec 12, 2021
b86224f
Fix align-cast for gost_grasshopper_cipher_do_ecb.
shanechko Dec 12, 2021
ac04583
Fix align-cast for gost_grasshopper_cipher_do_cbc
shanechko Dec 12, 2021
28369bb
Fix align-cast for acpkm_next.
shanechko Dec 12, 2021
3fb4376
Fix align-cast for gost_grasshopper_cipher_do_ctr.
shanechko Dec 15, 2021
f1a0f82
Fix align-cast for gost_grasshopper_cipher_do_ofb.
shanechko Dec 15, 2021
03e3cdf
Fix align-cast for gost_grasshopper_cipher_do_cfb.
shanechko Dec 15, 2021
49d62ca
Ensure data alignment for uint512_u.
shanechko Dec 16, 2021
7499536
Fix align-cast for test_derive.c
shanechko Dec 16, 2021
600af30
Add compilation option to emit warning about invalid cast-align.
shanechko Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ if (CMAKE_C_COMPILER_ID MATCHES "Clang")
set(CMAKE_C_FLAGS_RELEASE -O2)
set(CMAKE_C_FLAGS_DEBUG "-O0 -ggdb")
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -ggdb")
add_compile_options(-Werror -Wall -Wno-unused-parameter -Wno-unused-function -Wno-missing-braces -Qunused-arguments -Wno-deprecated-declarations)
add_compile_options(-Werror -Wall -Wcast-align -Wno-unused-parameter -Wno-unused-function -Wno-missing-braces -Qunused-arguments -Wno-deprecated-declarations)
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
set(CMAKE_C_FLAGS_RELEASE -O2)
set(CMAKE_C_FLAGS_DEBUG "-O0 -ggdb")
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O2 -ggdb")
add_compile_options(-Werror -Wall -Wno-unused-parameter -Wno-unused-function -Wno-missing-braces -Wno-error=unknown-pragmas -Wno-error=pragmas -Wno-deprecated-declarations)
add_compile_options(-Werror -Wall -Wcast-align -Wno-unused-parameter -Wno-unused-function -Wno-missing-braces -Wno-error=unknown-pragmas -Wno-error=pragmas -Wno-deprecated-declarations)
Copy link
Member

@vt-alt vt-alt Dec 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если мы хотим это фиксить для всех архитектур, то, видимо, надо -Wcast-align=strict. Чтоб и на x86 вылазили эти варнинги.

elseif(CMAKE_C_COMPILER_ID MATCHES "MSVC")
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
add_definitions(-D_CRT_DEPRECATED_NO_WARNINGS)
Expand Down