This repository was archived by the owner on Sep 27, 2022. It is now read-only.
Avoid using the pipe operator just once.#33
Open
RudManusachi wants to merge 1 commit intogothinkster:masterfrom
Open
Avoid using the pipe operator just once.#33RudManusachi wants to merge 1 commit intogothinkster:masterfrom
RudManusachi wants to merge 1 commit intogothinkster:masterfrom
Conversation
(see Style Guide https://github.com/christopheradams/elixir_style_guide#avoid-single-pipelines) overall code formatting more consistent
agenestar
approved these changes
Aug 2, 2019
Collaborator
|
I made a similar PR request to elixir-lang/elixir in the past and it got rejected, I think this one just comes down to personal preference. |
|
@shdblowers, hmm.. I just yesterday was looking into style guide and found this one which is approved by José Valim. |
Collaborator
|
I guess the key word in his response is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed using different styles in different parts
As stated in this style guide
now overall code formatting looks more consistent