Skip to content

Support sr.bind() #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: default
Choose a base branch
from
Open

Support sr.bind() #9

wants to merge 1 commit into from

Conversation

goto-bus-stop
Copy link
Owner

Going to be useful for a loadable-component thing I'm working on.

var sr = require('split-require')
var component = loadableComponent({
  load: sr.bind(null, './whatever')
  // vs function (cb) { sr('./whatever', cb) }
})

goto-bus-stop
goto-bus-stop commented Nov 24, 2017
View reviewed changes
plugin.js

function processBoundSplitRequire (row, node) {
var requirePath = node.arguments[1].arguments[0].value
var resolved = row.deps[requirePath]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also use this code for sr.call(null, 'whatever'), i think.

@goto-bus-stop goto-bus-stop changed the base branch from master to default November 19, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@goto-bus-stop