Skip to content

Make the Google button label different between Login and Registration #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cenon-delrosario merged 1 commit into from
Aug 31, 2025
Merged

Make the Google button label different between Login and Registration #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/views/devise/registrations/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<h2 class="heading">Register for GovHack <%= @competition.year %></h2>
<%= render 'components/registration_status', page: 'sign_up' %>
<div class="google-oath">
<%= link_to (render "devise/shared/google"), user_google_omniauth_authorize_path, method: :post %>
<%= link_to (render "devise/shared/google", locals: { google_label: 'Sign up with Google' }), user_google_omniauth_authorize_path, method: :post %>
<hr class="grey-border">
<p class="alt-text">or register below</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion app/views/devise/sessions/new.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<section class="signup-form">
<h2 class="heading">Log in to Hackerspace</h2>
<div class="google-oath">
<%= link_to (render "devise/shared/google"), user_google_omniauth_authorize_path, method: :post %>
<%= link_to (render "devise/shared/google", locals: { google_label: 'Log in with Google'}), user_google_omniauth_authorize_path, method: :post %>
<hr class="grey-border">
<p class="alt-text"> or log in below</p>
</div>
Expand Down
3 changes: 1 addition & 2 deletions app/views/devise/shared/_google.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
</div>
</div>
<div class="message">
<p>Sign up with Google</p>
<p>Log in with Google</p>
<p><%= locals[:google_label] %></p>
</div>
</div>
</div>
Loading