Skip to content

Fix competition end date calculation #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cenon-delrosario merged 1 commit into from
Aug 29, 2025
Merged

Fix competition end date calculation #477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/competition.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ def already_participating_in_a_competition_event?(event_assignment)
def in_sunday_judging?(time_zone)
four_pm = Time.new(end_time.year, end_time.month, end_time.day, 16, 0, 0, end_time.utc_offset)
is_after_four_pm = Region.region_time(time_zone) > four_pm.to_formatted_s(:number)
midday_after_end_date = Time.new(end_time.year, end_time.month, end_time.day + 1, 12, 0, 0, end_time.utc_offset)
end_date = Time.new(end_time.year, end_time.month, end_time.day) + 1.day
midday_after_end_date = Time.new(end_date.year, end_date.month, end_date.day, 12, 0, 0, end_time.utc_offset)
is_before_midday_next_day = Region.region_time(time_zone) < midday_after_end_date.to_formatted_s(:number)

is_after_four_pm && is_before_midday_next_day
Expand Down
Loading