Merged
Conversation
cadmiumcat
previously approved these changes
Jan 28, 2025
Contributor
cadmiumcat
left a comment
cadmiumcat
left a comment
There was a problem hiding this comment.
Thanks!
I've deployed this to dev, the logs in splunk include the hostname and no host as expected
stephencdaly
force-pushed
the
rename-host-field-in-logging
branch
from
eb2aca7 to
f7d15d8
Compare
lfdebrux
approved these changes
Jan 29, 2025
jamie-o-wilkinson
approved these changes
Jan 29, 2025
Rename the "host" logging field to "request_host". An additional "host" field is added to the logs that go to Splunk for Kenesis. This means we end up with 2 values for "host" making it difficult to filter searches by it.
stephencdaly
force-pushed
the
rename-host-field-in-logging
branch
from
f7d15d8 to
d98e6b9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Rename the "host" logging field to "hostname". An additional "request_host" field is added to the logs that go to Splunk for Kenesis. This means we end up with 2 values for "host" making it difficult to filter searches by it.
Things to consider when reviewing