Fix copied form not added to group if it has no questions#2605
Merged
stephencdaly merged 1 commit intomainfrom Mar 10, 2026
Merged
Fix copied form not added to group if it has no questions#2605stephencdaly merged 1 commit intomainfrom
stephencdaly merged 1 commit intomainfrom
Conversation
When copying a draft form with no questions, it was not being added to a group. This was because we were trying to create the GroupForm before the copied form had been saved. If the form has no associated questions, it would not have been assigned an ID yet, and the GroupForm creation would silently fail. Assign the form to the group after it has been saved to fix this.
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2605.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this pull request solve?
When copying a draft form with no questions, it was not being added to a group. This was because we were trying to create the GroupForm before the copied form had been saved. If the form has no associated questions, it would not have been assigned an ID yet, and the GroupForm creation would silently fail.
Assign the form to the group after it has been saved to fix this.
Things to consider when reviewing