Merged
Conversation
Previously we were using cssnano to minify our CSS, however, we were also getting warnings when running `bin/vite build` from esbuild which was also trying to minify our CSS and unable to parse the output of cssnano. Instead of trying to minify our CSS twice, we've decided just to use the Vite default, which is esbuild. This commit removes cssnano from this project. The size of the output CSS is slightly increased as a result of this change; - using cssnano the output CSS is 151386 bytes, - with esbuild the output CSS is 154086 bytes; but we think it's not a large enough increase to be an issue.
lfdebrux
force-pushed
the
ldeb-remove-cssnano
branch
from
ee14bc1 to
25d9b56
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2619.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Mar 11, 2026
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
Code change looks good and it's well explained 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Previously we were using cssnano to minify our CSS, however, we were also getting warnings when running
bin/vite buildfrom esbuild which was also trying to minify our CSS and unable to parse the output of cssnano.Instead of trying to minify our CSS twice, we've decided just to use the Vite default, which is esbuild. This commit removes cssnano from this project.
The size of the output CSS is slightly increased as a result of this change;
but we think it's not a large enough increase to be an issue.
Things to consider when reviewing