Skip to content

Fix content for Markdown preview when no value#2621

Merged
chao-xian merged 1 commit intomainfrom
fix-markdown-no-content
Mar 12, 2026
Merged

Fix content for Markdown preview when no value#2621
chao-xian merged 1 commit intomainfrom
fix-markdown-no-content

Conversation

@chao-xian
Copy link
Contributor

@chao-xian chao-xian commented Mar 11, 2026

Before the message to the user was specific to the Guidance page.

Before

image (7)

After

Screenshot 2026-03-11 at 1 05 06 pm

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

Before the message to the user was specific to the Guidance page.
@sonarqubecloud
Copy link

@chao-xian chao-xian marked this pull request as ready for review March 11, 2026 13:06
@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2621.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@hannahkc
Copy link
Contributor

Content is good!

Copy link
Contributor

@thomasiles thomasiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🏅

@chao-xian chao-xian added this pull request to the merge queue Mar 12, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2026
@chao-xian chao-xian added this pull request to the merge queue Mar 12, 2026
Merged via the queue into main with commit 4c247e4 Mar 12, 2026
8 checks passed
@chao-xian chao-xian deleted the fix-markdown-no-content branch March 12, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants