Skip to content

Remove welsh feature flag#2627

Merged
thomasiles merged 9 commits intomainfrom
remove-welsh-feature-flag
Mar 16, 2026
Merged

Remove welsh feature flag#2627
thomasiles merged 9 commits intomainfrom
remove-welsh-feature-flag

Conversation

@thomasiles
Copy link
Contributor

@thomasiles thomasiles commented Mar 13, 2026

Remove the Welsh feature flag from admin

Trello card: https://trello.com/c/gI4COCYo/2863-remove-welsh-feature-flag

Remove all uses of the feature flag and ignore the column.

The settings still need to be removed from the deploy repository but this is the first step to stop using it.

All welsh features should be fully enabled in all environments.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@thomasiles thomasiles marked this pull request as ready for review March 13, 2026 15:34
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2627.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Copy link
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nicely broken up and documented 🎉

@thomasiles thomasiles added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit 84b44f0 Mar 16, 2026
7 of 8 checks passed
@thomasiles thomasiles deleted the remove-welsh-feature-flag branch March 16, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants