Conversation
We had styles in _app_memorandum_of_understanding and _app_lists that were very similar, this commit de-duplicates the code. We use `govuk-spacing(4)` rather than 20px for the padding, as govuk-spacing(4) the same dimension for desktop viewports but also responsive for smaller viewports, this also matches what is in [_lists.scss in govuk-frontend][1]. [1]: https://github.com/alphagov/govuk-frontend/blob/5e14495c40ec61112d069da3e61c168e1ce40012/packages/govuk-frontend/src/govuk/core/_lists.scss
lfdebrux
force-pushed
the
ldeb-app-lists
branch
from
0fe3a1e to
eb0b533
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2629.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Mar 16, 2026
Contributor
DavidBiddle
left a comment
DavidBiddle
left a comment
There was a problem hiding this comment.
Sensible change, and the MOU pages look good on different screen sizes in the review app 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
We had styles in
_app_memorandum_of_understandingand_app_liststhat were very similar, this commit de-duplicates the code.We use
govuk-spacing(4)rather than 20px for the padding, asgovuk-spacing(4)has the same dimension for desktop viewports but is also responsive for smaller viewports.Things to consider when reviewing