Make removing the Welsh content for a form reset the Welsh task#2632
Merged
alice-carr merged 1 commit intomainfrom Mar 17, 2026
Merged
Make removing the Welsh content for a form reset the Welsh task#2632alice-carr merged 1 commit intomainfrom
alice-carr merged 1 commit intomainfrom
Conversation
alice-carr
force-pushed
the
reset-welsh-task
branch
4 times, most recently
from
5c26641 to
fd96741
Compare
alice-carr
commented
Mar 17, 2026
When a user removes all the welsh content from a form, we delete the welsh version and reset the welsh task
alice-carr
force-pushed
the
reset-welsh-task
branch
from
fd96741 to
b417f03
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2632.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
thomasiles
approved these changes
Mar 17, 2026
Contributor
thomasiles
left a comment
thomasiles
left a comment
There was a problem hiding this comment.
Looks good and works for me in testing 🏅
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
When a user removes all the welsh content from a form, we delete the welsh version and reset the welsh task.
Trello card: https://trello.com/c/XhHcx8oz/2795-make-removing-the-welsh-content-for-a-form-reset-the-welsh-task
Things to consider when reviewing