Ensure agreement_type is specified for MouSignatures added using rake tasks#2634
Merged
stephencdaly merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
We set a default value for the agreement_type when we added the column so we pre-populated existing records with that value. Remove the default value to make sure we're always deliberately setting the correct agreement_type for new records.
MouSignatures now have an agreement_type of "crown" or "non_crown". Update the rake task to require specifying the agreement_type.
stephencdaly
force-pushed
the
add-agreement-type-to-mou-signature-rake-task
branch
from
66abf70 to
aa886b7
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2634.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
SamJamCul
approved these changes
Mar 16, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
DavidBiddle
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
I'm not sure if this rake task is still needed, but now the MouSignatures have an
agreement_typeit should always be explicitly specified.Add a migration to remove the default value for agreement_type to ensure we never mistakenly leave it as the default when we don't intend to.
Things to consider when reviewing