Skip to content

Rename unprocessable_entity to unprocessable_content#1586

Merged
DavidBiddle merged 1 commit intomainfrom
rename-unprocessable-entity
Aug 18, 2025
Merged

Rename unprocessable_entity to unprocessable_content#1586
DavidBiddle merged 1 commit intomainfrom
rename-unprocessable-entity

Conversation

@DavidBiddle
Copy link
Contributor

@DavidBiddle DavidBiddle commented Aug 15, 2025

What problem does this pull request solve?

When the 422 status was initially proposed in RFC4918 (2007), it was called 'Unprocessable entity'.

When it became a standard in RFC9110 (2022), it was renamed 'Unprocessable content'.

Rack now supports it as :unprocessable_content and deprecated :unprocessable_entity in v3.1.0. This commit updates it to use the new name.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@DavidBiddle DavidBiddle marked this pull request as ready for review August 15, 2025 11:14
@DavidBiddle DavidBiddle force-pushed the rename-unprocessable-entity branch 3 times, most recently from 9284da6 to 1fcb34e Compare August 18, 2025 10:10
@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

When the 422 status was initially proposed in
[RFC4918](https://datatracker.ietf.org/doc/html/rfc4918) (2007), it was
called 'Unprocessable entity'.

When it became a standard in
[RFC9110](https://datatracker.ietf.org/doc/html/rfc9110) (2022), it was
renamed 'Unprocessable content'.

Rack now supports it as `:unprocessable_content` and has deprecated
`:unprocessable_entity`. This commit updates it to use the new name.
@DavidBiddle DavidBiddle force-pushed the rename-unprocessable-entity branch from 1fcb34e to 5b426f6 Compare August 18, 2025 10:55
@DavidBiddle DavidBiddle enabled auto-merge August 18, 2025 10:55
@sonarqubecloud
Copy link

@DavidBiddle DavidBiddle merged commit 9cc1cc6 into main Aug 18, 2025
9 of 10 checks passed
@DavidBiddle DavidBiddle deleted the rename-unprocessable-entity branch August 18, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants