Skip to content

Remove deprecated page and active support depreciation warnings#1587

Merged
theseanything merged 2 commits intomainfrom
remove-deprecated
Aug 15, 2025
Merged

Remove deprecated page and active support depreciation warnings#1587
theseanything merged 2 commits intomainfrom
remove-deprecated

Conversation

@theseanything
Copy link
Contributor

@theseanything theseanything commented Aug 15, 2025

The deprecated route (/deprecated) and associated controller method
(ErrorsController#deprecated) are no longer needed since V1 API
usage has been removed in PR #993

This also switches off the active support deprecation warnings features as it's not being used.

@theseanything theseanything requested a review from lfdebrux August 15, 2025 12:48
@lfdebrux
Copy link
Contributor

@theseanything I think there's some other code from #942 still lying around, including config/initializers/forms_api_deprecations.rb.

@theseanything theseanything changed the title Remove deprecated route and controller method Remove deprecated page and active support depreciation warnings Aug 15, 2025
@theseanything
Copy link
Contributor Author

@theseanything I think there's some other code from #942 still lying around, including config/initializers/forms_api_deprecations.rb.

Removed that and the added active support deprecation warnings config.

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

The deprecated route (/deprecated) and associated controller method
(ErrorsController#deprecated) are no longer needed since V1 API
usage has been removed.

Also removed deprecators.
We no longer use this feature.
@sonarqubecloud
Copy link

@theseanything theseanything merged commit 4fe6cac into main Aug 15, 2025
9 of 10 checks passed
@theseanything theseanything deleted the remove-deprecated branch August 15, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants