Skip to content

Use localhost for test database connections#1588

Merged
theseanything merged 1 commit intomainfrom
fix-db-config
Aug 18, 2025
Merged

Use localhost for test database connections#1588
theseanything merged 1 commit intomainfrom
fix-db-config

Conversation

@theseanything
Copy link
Contributor

This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.

@theseanything theseanything requested a review from a team August 15, 2025 12:49
@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.
@sonarqubecloud
Copy link

@theseanything theseanything merged commit 7bb908f into main Aug 18, 2025
9 of 10 checks passed
@theseanything theseanything deleted the fix-db-config branch August 18, 2025 10:25
chao-xian added a commit to govuk-forms/forms-admin that referenced this pull request Sep 1, 2025
This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.

Follows govuk-forms/forms-runner#1588
chao-xian added a commit to govuk-forms/forms-admin that referenced this pull request Sep 1, 2025
This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.

Follows govuk-forms/forms-runner#1588
chao-xian added a commit to govuk-forms/forms-admin that referenced this pull request Sep 2, 2025
This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.

Follows govuk-forms/forms-runner#1588
chao-xian added a commit to govuk-forms/forms-admin that referenced this pull request Sep 3, 2025
This fixes an issue if using psql container in docker and running the tests on the host machine. By specifying "localhost" this ensures the connection is done via TCP rather than sockets, which is needed to connect to the container.

Follows govuk-forms/forms-runner#1588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants