Skip to content

Small refactor to logging for send submission job #1757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lfdebrux wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Small refactor to logging for send submission job #1757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
191b480
Rename submission_email_sent event to submission_sent
lfdebrux Nov 26, 2025
28ce3ef
Use same time for delivery attempt in submission record and metrics
lfdebrux Nov 26, 2025
d64caba
Change logging of sent submission to be more like logging of submit
lfdebrux Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/jobs/send_submission_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@ def perform(submission)
set_submission_logging_attributes(submission)

message_id = AwsSesSubmissionService.new(submission:).submit
sent_at = Time.zone.now

submission.update!(
mail_message_id: message_id,
delivery_status: :pending,
last_delivery_attempt: Time.zone.now,
last_delivery_attempt: sent_at,
)

milliseconds_since_scheduled = (Time.current - scheduled_at_or_enqueued_at).in_milliseconds.round
EventLogger.log_form_event("submission_email_sent", { milliseconds_since_scheduled: })
milliseconds_since_scheduled = (sent_at - scheduled_at_or_enqueued_at).in_milliseconds.round
LogEventService.log_submission_sent(submission, milliseconds_since_scheduled:)
CloudWatchService.record_submission_sent_metric(milliseconds_since_scheduled)
rescue StandardError
CloudWatchService.record_job_failure_metric(self.class.name)
Expand Down
13 changes: 13 additions & 0 deletions app/services/log_event_service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@ def self.log_submit(context, requested_email_confirmation:, preview:, submission
end
end

def self.log_submission_sent(submission, **kwargs)
additional_context = {
submission_type: submission.form.submission_type,
submission_format: submission.form.submission_format,
}.merge(kwargs)

if submission.preview?
EventLogger.log_form_event("preview_submission_sent", additional_context)
else
EventLogger.log_form_event("submission_sent", additional_context)
end
end

def log_page_save
EventLogger.log_page_event(log_event, @step.question.question_text, skipped_question?)
if is_starting_form?
Expand Down