Add job to send a batch of submissions for a form#1901
Merged
Conversation
stephencdaly
force-pushed
the
add-batched-submissions-job
branch
from
09b279d to
5ca0574
Compare
stephencdaly
force-pushed
the
add-service-to-send-batch-submissions
branch
5 times, most recently
from
38a3d43 to
72f905b
Compare
stephencdaly
force-pushed
the
add-batched-submissions-job
branch
from
5ca0574 to
d5f802d
Compare
Base automatically changed from
add-service-to-send-batch-submissions
to
main
February 17, 2026 14:24
SamJamCul
force-pushed
the
add-batched-submissions-job
branch
2 times, most recently
from
2443b2c to
c43f10a
Compare
SamJamCul
force-pushed
the
add-batched-submissions-job
branch
4 times, most recently
from
781fe3e to
7861825
Compare
This scopes submission based on their created_at, form_id and mode. The given date is converted to the local time before the comparison to the created_at value. Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
Add a job that will send an email containing CSV(s) of submissions for a given form on a given day for a given mode. This job is not scheduled by anything yet. Co-authored-by: Samuel Culley <samuel.culley@digital.cabinet-office.gov.uk>
SamJamCul
force-pushed
the
add-batched-submissions-job
branch
from
7861825 to
5ccc9fd
Compare
stephencdaly
commented
Feb 19, 2026
db/migrate/20260218110428_add_index_on_form_id_and_created_at_and_mode_to_submissions.rb
Outdated
Show resolved
Hide resolved
stephencdaly
commented
Feb 19, 2026
SamJamCul
force-pushed
the
add-batched-submissions-job
branch
from
df1446e to
e91e7b2
Compare
This index will be used to locate a batch of submissions for daily batching. Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
This scope orders a list of submissions by their form's udpated_at, which is used as a proxy for its version, and then the submission date. The intention is to use this in the CSV generation for submission batches, where we'll need to maintain the order that submissions were made, but keep them in version clusters Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
The CSV generator now takes a submission query, and creates a set of CSVs based on how many different versions it can pick out. If two submissions have different versions but would still have the same CSV headers, then they will be part of the same CSV. Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
Shifts the checks for a form having a submission_email out of the submission batch service and into the batch job. This will mean that the job will terminate early when no submission_email is present, rather than continuing even though no email gets sent.
SamJamCul
force-pushed
the
add-batched-submissions-job
branch
from
e91e7b2 to
29e494e
Compare
|
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
SamJamCul
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/fMG08XG5
Add a job that will send an email containing CSV(s) of submissions for a given form on a given day for a given mode.
This job is not scheduled by anything yet.
Things to consider when reviewing