Skip to content

Update ses delivery and bounce notifications to handle weekly deliveries #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamJamCul merged 3 commits into from
Mar 25, 2026

Handle weekly batch receiving submissions

07beb61
Select commit
Loading
Failed to load commit list.
Merged

Update ses delivery and bounce notifications to handle weekly deliveries #1981

Handle weekly batch receiving submissions
07beb61
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 24, 2026 in 30s

Quality Gate passed

Issues
23 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
56.4% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 184 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "logs complaint event with correct details" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPY&open=AZ0KgTX4IpZiw5iiLnPY&pullRequest=1981

Check failure on line 175 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "processing complaint notifications" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPP&open=AZ0KgTX3IpZiw5iiLnPP&pullRequest=1981

Check failure on line 52 in spec/jobs/receive_submission_deliveries_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "something-else" 4 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0fT8RxBCmY88OxGngs&open=AZ0fT8RxBCmY88OxGngs&pullRequest=1981

Check failure on line 98 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "does not set failed_at on the delivery" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPW&open=AZ0KgTX4IpZiw5iiLnPW&pullRequest=1981

Check failure on line 96 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "preview-live" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPT&open=AZ0KgTX3IpZiw5iiLnPT&pullRequest=1981

Check failure on line 121 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "when there is a bounce object with detailed information" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPX&open=AZ0KgTX4IpZiw5iiLnPX&pullRequest=1981

Check failure on line 114 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "does not alert to Sentry" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPS&open=AZ0KgTX3IpZiw5iiLnPS&pullRequest=1981

Check failure on line 150 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "{{ default }}" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPM&open=AZ0KgTX3IpZiw5iiLnPM&pullRequest=1981

Check failure on line 69 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "logs form event with correct details" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPN&open=AZ0KgTX3IpZiw5iiLnPN&pullRequest=1981

Check failure on line 97 in spec/jobs/receive_submission_deliveries_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Form event" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0fWjb7hY8XpAfU07PE&open=AZ0fWjb7hY8XpAfU07PE&pullRequest=1981

Check failure on line 88 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "alerts to Sentry that there was a bounced delivery" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPZ&open=AZ0KgTX4IpZiw5iiLnPZ&pullRequest=1981

Check failure on line 160 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "does not include bounced recipients in the Sentry event" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPO&open=AZ0KgTX3IpZiw5iiLnPO&pullRequest=1981

Check failure on line 575 in spec/lib/tasks/submissions.rake_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "2024-01-02T02:00:00Z" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0fkavjDAKfaaDBTn13&open=AZ0fkavjDAKfaaDBTn13&pullRequest=1981

Check failure on line 84 in app/jobs/receive_submission_bounces_and_complaints_job.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "{{ default }}" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTcOIpZiw5iiLnPb&open=AZ0KgTcOIpZiw5iiLnPb&pullRequest=1981

Check failure on line 145 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "includes bounce details in the Sentry event" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPL&open=AZ0KgTX3IpZiw5iiLnPL&pullRequest=1981

Check failure on line 44 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "processing bounce notifications" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPR&open=AZ0KgTX3IpZiw5iiLnPR&pullRequest=1981

Check failure on line 669 in spec/lib/tasks/submissions.rake_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "usage: rake submissions:redeliver_batches_by_date[<form_id>,<start_timestamp>,<end_timestamp>,<dry_run>] " 4 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0fkavjDAKfaaDBTn14&open=AZ0fkavjDAKfaaDBTn14&pullRequest=1981

Check failure on line 127 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "logs the bounce details" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPQ&open=AZ0KgTX3IpZiw5iiLnPQ&pullRequest=1981

Check failure on line 103 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "logs form event with preview flag" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPV&open=AZ0KgTX4IpZiw5iiLnPV&pullRequest=1981

Check failure on line 95 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "when it is for a preview submission" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPU&open=AZ0KgTX4IpZiw5iiLnPU&pullRequest=1981

Check failure on line 62 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "updates the delivery record's failed_at and failure_reason" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX3IpZiw5iiLnPK&open=AZ0KgTX3IpZiw5iiLnPK&pullRequest=1981

Check failure on line 52 in spec/jobs/receive_submission_bounces_and_complaints_job_spec.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "when it is for a live submission" 3 times. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTX4IpZiw5iiLnPa&open=AZ0KgTX4IpZiw5iiLnPa&pullRequest=1981

Check failure on line 69 in app/jobs/receive_submission_bounces_and_complaints_job.rb

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a default clause to this "case" statement. 

See more on https://sonarcloud.io/project/issues?id=alphagov_forms-runner&issues=AZ0KgTcOIpZiw5iiLnPc&open=AZ0KgTcOIpZiw5iiLnPc&pullRequest=1981
View more details on SonarQubeCloud