Open
Conversation
This is redundant with autoreconf error that will print: [...] aclocal-1.16: error: couldn\'t open directory \'gphoto-m4\': No such file or directory at this point, people are supposed to turn to autogen.sh if familiar with autotools based packages or README or INSTALL for others.
These versions should be available on most popular distributions at this time.
Not sure if any other target would use it but configure.ac is definitely not the place to set it.
Use automake += operator to add source, cppflags and ldadd to gphoto2 target directly from optional features conditionals. Specifying these files in EXTRA_DIST becomes unneeded. Add i18n.h to gphoto2_SOURCES as it is included there and makes it redundant to specify in EXTRA_DIST.
And use autoconf provided variable names allowing removal of various intermediate variables. Use AS_IF instead of raw if in affected blocks as is recommanded by autoconf.
EvaSDK
force-pushed
the
autotools-updates
branch
from
1937e85 to
500f9ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a first throw at what I had in mind concerning autotools changes.
Going forward, we could replace readline by ax_readline macro, not sure if it would work fine with prefix support though.
jpeg detection could probably be changed to use GP_CHECK_LIBRARY if you are ready to stop supporting systems that do not ship a pkgconfig for it. Afaik, most distributions now do.
exif check could be simplified to require 0.6.9. This release is quite old already, it seems reasonable to require it rather than an older one.
For cdk and aalib, besides contributing upstream it seems unlikely the checks can be simplified.