Merged
Conversation
…latform install scripts, hardcoded API URL, test/benchmark modes only
…nual registration step for hackathon participants
…e --anonymous flag from CLI - Update install scripts to use GitHub authentication - Re-enable all submission modes - Simplify authentication flow to GitHub OAuth only
msaroufim
changed the title
msaroufim
commented
Jun 8, 2025
There was a problem hiding this comment.
Pull Request Overview
Adds dedicated installation scripts and preconfiguration for hackathon participants, and updates error messaging and documentation to streamline setup.
- Preconfigure the POPCORN_API_URL at startup
- Introduce bash and PowerShell installer scripts for hackathon mode
- Update CLI error message and docs with quick-install and example code
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Set default API URL and removed manual env-var check |
| src/cmd/mod.rs | Updated error text to reference the popcorn-cli register command |
| install.sh | New bash installer script for Unix/Linux/macOS |
| install.ps1 | New PowerShell installer script for Windows |
| docs/AMD_workshop/example.py | Added sample AMD workshop kernel implementation |
| docs/AMD_workshop/README.md | Added hackathon quick-install instructions |
Comments suppressed due to low confidence (2)
src/cmd/mod.rs:114
- [nitpick] Error messages should use backticks around CLI commands for clarity, e.g.,
popcorn-cli registerinstead of 'popcorn-cli register'.
"cli_id not found in config file ({}). Please run 'popcorn-cli register' first."
install.ps1:4
- The
$Forceparameter is defined but not used; implement its behavior or remove the parameter.
[switch]$Force = $false
S1ro1
approved these changes
Jun 8, 2025
Member
S1ro1
left a comment
S1ro1
left a comment
There was a problem hiding this comment.
Just remove from .gitignore, can merge after
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
S1ro1
approved these changes
Jun 8, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…de/popcorn-cli into hackathon-install-scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added scripts for both linux based and Windows based setup which would
With some doc instructions on what people should do at the physical workshop
Tested so far on my local mac and doing windows now