-
Notifications
You must be signed in to change notification settings - Fork 18
WIP rust port #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- rust/.gitignore: Language not supported
- rust/build.sh: Language not supported
Comments suppressed due to low confidence (1)
rust/src/models/mod.rs:27
- [nitpick] The field name 'title_text' in GpuItem might be less clear given its usage; consider renaming it to 'name' for better clarity and consistency.
pub struct GpuItem {
| if arg == "gpu" || arg == "gpus" { | ||
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | ||
| } else if arg == "leaderboard" && parts.len() > 2 { |
Copilot
AI
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GPU directive branch uses parts[2..] without ensuring that the directive includes GPU identifiers. Consider adding a check to ensure parts.len() >= 3 before accessing parts[2..].
| if arg == "gpu" || arg == "gpus" { | |
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | |
| } else if arg == "leaderboard" && parts.len() > 2 { | |
| if (arg == "gpu" || arg == "gpus") && parts.len() >= 3 { | |
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | |
| } else if arg == "leaderboard" && parts.len() >= 3 { |
This works right now, I managed to push a job and get results back in the terminal https://github.com/gpu-mode/discord-cluster-manager/actions/runs/14344920618
To install
./build.shSome pending issues
This completely borks the terminal output after running it once so looks quite uglyDoesn't anymore 💪Logs