Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a Linux Landlock LSM sandbox (csrc/landlock.cpp) that restricts filesystem write access during untrusted kernel evaluation. The sandbox allows read access to the entire filesystem but limits writes to /tmp and /dev. It also consolidates the existing prctl hardening calls (previously in manager.cpp) into the new install_landlock() function. A new exploit test (submission_replace_torch) is added to verify that attempts to write a shadow torch.py file to the current working directory are blocked.
Changes:
- New
csrc/landlock.cppimplementinginstall_landlock()which sets up a Landlock ruleset (read-only everywhere, read-write in/tmpand/dev) and appliesprctlhardening. csrc/manager.cppreplaces the inlineprctlcalls with a singleinstall_landlock()call.- New exploit
exploits/submission_replace_torch.pyand corresponding entry inexploits/run_all.pyto test the defense.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
csrc/landlock.cpp |
New file implementing the Landlock filesystem sandbox and prctl hardening |
csrc/manager.cpp |
Replaces inline prctl calls with install_landlock() |
CMakeLists.txt |
Adds landlock.cpp to the build |
exploits/submission_replace_torch.py |
New exploit testing file-write-via-cwd attack |
exploits/run_all.py |
Registers the new exploit in the test suite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
restrict file-system write access