Harden checker and warmup behavior#24
Open
josusanmartin wants to merge 1 commit intogpu-mode:masterfrom
Open
Conversation
1d62323 to
f237fa0
Compare
Author
|
Linking this PR to #23. Maintainer note: the code changes here are intended as interim hardening, not a complete fix for the signature/authentication issue. What this PR helps with immediately:
What still needs a follow-up design change:
|
f237fa0 to
908e6af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a small set of hardening changes related to issue #23.
Related issue: #23 (
pygpubench Signature Authentication Bypass)Changes in this PR
csrc/check.cuso malformed expected outputs fail closedWhy this is not a full fix
These changes reduce attack surface, but they do not fully resolve the architectural problem described in #23.
The stronger follow-up fix is still to redesign result authentication / validation so the worker process cannot forge accepted benchmark output from inside the same address space.