Skip to content

fix: eslint config and plugins#24

Merged
wizenink merged 10 commits intogpul-org:mainfrom
wizenink:eslint-fixes
Jul 11, 2025
Merged

fix: eslint config and plugins#24
wizenink merged 10 commits intogpul-org:mainfrom
wizenink:eslint-fixes

Conversation

@wizenink
Copy link
Contributor

@wizenink wizenink commented Jul 8, 2025

  • Added eslint plugins to devDependencies to bypass a pnpm transient dependencies error
  • Ignored .docusaurus and build dirs in linting
  • moved ts and react rules to js block (We try to not format Markdown as JS :) )
  • Added modified js linting to code blocks inside Markdown files

@wizenink wizenink requested a review from a team as a code owner July 8, 2025 08:16
@wizenink
Copy link
Contributor Author

wizenink commented Jul 9, 2025

Any comment or improvement on this?

@jorgeteixe
Copy link
Member

I would update all the files so they are consistent with eslint, currently:

✖ 24 problems (24 errors, 0 warnings)

And maybe add a GitHub Workflow that checks eslint on open PRs?

@wizenink
Copy link
Contributor Author

wizenink commented Jul 9, 2025

Adding #21 as linked issue.
Does pre-commit.com looks right to you for pre-commit hooks look right to you?
I can add it both for git hooks and as a GH Workflow

@jorgeteixe
Copy link
Member

Yeah, I'm not used to git-hooks. I like enforcing stuff server side with the workflows and then make them required in the repository to pass to allow merge.

If it works, I don't mind. What I want is to have main in a "green ✅" state after merging this PR.

@wizenink
Copy link
Contributor Author

wizenink commented Jul 9, 2025

Roger, maybe start with CI to enforce in server, and maybe later include git hooks ( I like them because they prevent the usual PR incremental commit overload to pass CI 😄 )

@wizenink
Copy link
Contributor Author

Ok, right now, linting and formatting are implemented on CI. Will commit with prettier passing, and should be ready to check

@wizenink
Copy link
Contributor Author

Ok, linting and formatting are implemented on CI. We should keep this simple, I'll open another MR later to implement pre-commit git hooks.
Git hooks should be opt-int, just in case anyone prefers re-commiting again and again on the MR

Copy link
Member

@Kr4is Kr4is left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, the CI is currently checking the linting, also could be great to could make it works in locally before upload it to git. 💪🏼

But as you said, we will add this functionality in other PR. Great Job! 👍🏼

@wizenink wizenink merged commit 4347286 into gpul-org:main Jul 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants