fix: eslint config and plugins#24
Conversation
wizenink
commented
Jul 8, 2025
- Added eslint plugins to devDependencies to bypass a pnpm transient dependencies error
- Ignored .docusaurus and build dirs in linting
- moved ts and react rules to js block (We try to not format Markdown as JS :) )
- Added modified js linting to code blocks inside Markdown files
|
Any comment or improvement on this? |
|
I would update all the files so they are consistent with eslint, currently:
And maybe add a GitHub Workflow that checks eslint on open PRs? |
|
Adding #21 as linked issue. |
|
Yeah, I'm not used to git-hooks. I like enforcing stuff server side with the workflows and then make them required in the repository to pass to allow merge. If it works, I don't mind. What I want is to have |
|
Roger, maybe start with CI to enforce in server, and maybe later include git hooks ( I like them because they prevent the usual PR incremental commit overload to pass CI 😄 ) |
|
Ok, right now, linting and formatting are implemented on CI. Will commit with prettier passing, and should be ready to check |
|
Ok, linting and formatting are implemented on CI. We should keep this simple, I'll open another MR later to implement pre-commit git hooks. |
Kr4is
left a comment
There was a problem hiding this comment.
Okay, the CI is currently checking the linting, also could be great to could make it works in locally before upload it to git. 💪🏼
But as you said, we will add this functionality in other PR. Great Job! 👍🏼