Merged
Conversation
jorgeteixe
requested changes
Jul 11, 2025
Member
jorgeteixe
left a comment
jorgeteixe
left a comment
There was a problem hiding this comment.
Aside from moving the docs to another file, for me its okay to set a default to use the pre-commit hook. I think it is best practice.
Then, leave the option for opt-out.
jorgeteixe
approved these changes
Jul 11, 2025
Member
jorgeteixe
left a comment
jorgeteixe
left a comment
There was a problem hiding this comment.
Can't test rn, but looks neat
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step to close #21
I chose to make the pre-commit hooks opt-in, in case anyone wants to fix code formatting on CI, and to make devs used to the system and rules, but this can be enforced anytime.