Open
Conversation
Author
|
@gr2m could u help take a look this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of pull requests where the
headrepository is missing or null, ensuring the application does not incorrectly treat such PRs as forks. It also adds a targeted test case for this scenario and refines the utility functions to be more robust against missing repository data.Test improvements:
handle-pull-request.test.tsto verify that pull requests without aheadrepository are not incorrectly identified as forks.Bug fixes and robustness:
isForkutility inutils.tsto safely handle cases whereheadorrepomay be null or undefined, preventing runtime errors.generatePullRequestWebhooktest utility to support aheadRepoparameter, allowing tests to simulate pull requests with missing or customheadrepositories. [1] [2]