Refactor DependencyGraphs to Gradle BuildService pattern #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunkumar9t2
requested review from
adarsh-grabtaxi,
arnav-grabtaxi,
arunsampathkumar-grabtaxi,
minkuanlim-grabtaxi and
vanminh-grabtaxi
as code owners
Convert DependencyGraphs from Dagger singleton to Gradle BuildService to ensure dependency graph construction happens during task execution phase rather than configuration phase, following Gradle best practices. Changes: - Add DependencyGraphsService with configure()/get() pattern - Refactor consumers to use GradleProvider<DependencyGraphsService> - Update variant filter interface from property to function for clarity
Replace hacky reflection code in DefaultAndroidUnitTestDataExtractorTest with a proper FakeDependencyGraphsService class that extends DefaultDependencyGraphsService and accepts DependencyGraphs in constructor.
arunsampathkumar-grabtaxi
force-pushed
the
refactor/dependency-graphs-build-service
branch
from
c35b560 to
78c2612
Compare
minkuanlim-grabtaxi
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert DependencyGraphs from Dagger singleton to Gradle BuildService to ensure dependency graph construction happens during task execution phase rather than configuration phase, following Gradle best practices.
Changes: